Closet Goblin Broken in 1.3.1

[Zarlemagne]

Alot of the equipment slots are blanked out and doesn't swap sets properly anymore

Anyone have a clue how to fix this ?

I know the current author doesn't have the time to work on this anymore, so if someone would take it over alot of people would love you

[Aiiane]

Replace all instances of GameData.ItemSlots in the code with GameData.EquipSlots and it should work again.

[Zarlemagne]

Originally Posted by Aiiane

Replace all instances of GameData.ItemSlots in the code with GameData.EquipSlots and it should work again.

Thx for looking into ths Aiiane

One small problem, there wasn't any instances of GameData.ItemSlots in any of the files i have (checked 2.2.1.2 and 2.3.0.1 beta)

As there was 4 instances of GameData.EquipSlots (3 in ClosetGoblin.lua and one in ClosetGoblinCharacterWindow.lua if i remember right), i've assumed you accidentally put them the wrong way round in your post

So have have changed the GameData.EquipSlots to GameData.ItemSlots

I'll test it later today - 20 Aug - when EU get the patch

[Garkin]

Originally Posted by Zarlemagne

Thx for looking into ths Aiiane

One small problem, there wasn't any instances of GameData.ItemSlots in any of the files i have (checked 2.2.1.2 and 2.3.0.1 beta)

As there was 4 instances of GameData.EquipSlots (3 in ClosetGoblin.lua and one in ClosetGoblinCharacterWindow.lua if i remember right), i've assumed you accidentally put them the wrong way round in your post

So have have changed the GameData.EquipSlots to GameData.ItemSlots

I'll test it later today - 20 Aug - when EU get the patch

Prior to 1.3.1 there was both tables GameData.ItemSlots and GameData.EquipSlots with the same data. Now it seems that GameData.ItemSlots was removed.
So if there is no instance of GameData.ItemSlots in Closet Goblin source code, fix will be a bit more complicated. I will take a look into the code when EU servers will be online and all my own addons will be ready for new patch.

[Garkin]

Closet Goblin does not work because of changes to CharacterWindow and also to GameData.EquipSlots.
There is a new item slot for event items in CharacterWindow, so you have to add it to Closet Goblin as well:

open ClosetGoblin.xml and find:
<!-- Left Column -->
<!-- Helm slot -->

replace it with:
<!-- Left Column -->
<!-- Event slot -->
<Button name="$parentSlot15" inherits="ClosetGoblinEquipmentButton" id="15">
<Anchors>
<Anchor point="top" relativePoint="bottom" relativeTo="$parentSlot9">
<AbsPoint x="0" y="0" />
</Anchor>
</Anchors>
</Button>
<!-- Helm slot -->

Next change what you need to do is to find all instances of this code:
for slotName, slot in pairs(GameData.EquipSlots) do
-- some commands
end

and replace it with:
for slotName, slot in pairs(GameData.EquipSlots) do
if slot ~= GameData.EquipSlots.EITHER_HAND then
-- some comands
end
end

After this changes it should work correctly.

I did not try if this fix works for old saved sets which does not have stored information about event slot. If there is any error, I recommend to delete old sets and create a new one.

[Zarlemagne]

Thx Garkin that works a treat

Just had to make your changes and delete all my old sets and it now working perfectly again

I'll even not kill you "much" when i see you in RvR for that fix

[kassdelire]

Originally Posted by Garkin

Next change what you need to do is to find all instances of this code:
for slotName, slot in pairs(GameData.EquipSlots) do
-- some commands
end

and replace it with:
for slotName, slot in pairs(GameData.EquipSlots) do
if slot ~= GameData.EquipSlots.EITHER_HAND then
-- some comands
end
end

this code can be found in two files


C:\Warhammer Online - Age of Reckoning\interface\AddOns\ClosetGoblin\ClosetGobl in.lua
lines :
377: for slotName, slot in pairs(GameData.EquipSlots) do
559: for slotName, slot in pairs(GameData.EquipSlots) do
589: for slotName, slot in pairs(GameData.EquipSlots) do

and
C:\Warhammer Online - Age of Reckoning\interface\AddOns\ClosetGoblin\ClosetGobl inCharacterWindow.lua
line:
382: for slotName, slot in pairs(GameData.EquipSlots) do

[punish]

After changing all those, i can't click on the closetgolbin icon. need help please.

[Garkin]

Originally Posted by punish

After changing all those, i can't click on the closetgolbin icon. need help please.

Here is ClosetGoblin 2.2.1.2 with changes mentioned above. This is just temporary fix, so I did not update version information in mod file.

http://rapidshare.com/files/26973845..._for_1.3.1.zip

When you start this version for first time, you have to remove all your old equipment sets and create new ones.

[Jinnz]

Thanks for this Garkin.

Ive always used EQsets but its broken. This will do.

[Zox]

Thanks for the fix!

[Snabel]

Is there actually an actively updated wardrobe-type-mod for WAR?

I've been using EquipmentSets, which had the advantage over Closet Goblin in that it also switches morale abilities.
But now, both addons need to be manually updated for their positions to be saved and none have a final version that handles same armour items with different talismans slotted.

Closet Goblin has a beta out that should address the latter, talismanrelated issue, but the author himself has stated that he doesn't have much time to complete that feature. Morales are in the works after that, but at this rate, who knows if it'll ever happen.

Is there really not a single maintained addon out there that lets you define and switch gear/tactics/morale abilities, all in one go?

[Antailia]

Originally Posted by Snabel

Is there really not a single maintained addon out there that lets you define and switch gear/tactics/morale abilities, all in one go?

You can do that with Morale Set. This let's you change morale the same way you do with tactics. You can also connect it to you tacticset so that with tacticset 1 you will automatically use morale set 1 etc. Closet Goblin can be set to switch tactics with each equipmentset.

[Eloora]

Nevermind, cleared all old CG data, relogged and it worked. Appreciate the fix.

[Snabel]

Originally Posted by Antailia

You can do that with Morale Set. This let's you change morale the same way you do with tactics. You can also connect it to you tacticset so that with tacticset 1 you will automatically use morale set 1 etc. Closet Goblin can be set to switch tactics with each equipmentset.

Excellent tip, thanks!